Re: [PATCH v3 07/25] sequencer: completely revamp the "todo" script parsing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 11, 2016, 16:58 UTC
- Message-ID
- <xmqqvawyakme.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.2.20.1610111238470.35196@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> In the end, I decided to actually *not* use strbuf_add_unique_abbrev() > here because it really makes the code very much too ugly after the > introduction of short_commit_name():
It's perfectly fine not to use that function when it does not make sense; we shouldn't use it (or anything for that matter) just for the sake of using it.