Re: [PATCH 04/22] sequencer: future-proof remove_sequencer_state()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 29, 2016, 11:19 UTC
Message-ID: <alpine.DEB.2.20.1608291317370.129229@virtualbox>
In-Reply-To: <alpine.DEB.2.20.1608291258280.129229@virtualbox>

Hi Dennis,

On Mon, 29 Aug 2016, Johannes Schindelin wrote:

Show 13 quoted lines

> On Mon, 29 Aug 2016, Dennis Kaarsemaker wrote:
> 
> > On ma, 2016-08-29 at 10:04 +0200, Johannes Schindelin wrote:
> > 
> > > +       if (read_and_refresh_cache(opts))
> > > +               return -1;
> > > +
> > 
> > This doesn't seem to be related to the get_dir changes?
> 
> Good eyes.
> 
> Let me investigate why I have it here...

Unfortunately my reflogs got corrupted by the git-worktree implementations, so I cannot back that far.

Looking at the code, and after running the tests, I am convinced that it is a leftover of some misguided attempt to implement "git rebase -i --abort" in sequencer_rollback().

I removed this hunk from the patch.

Again, Thank you so much for your review! Dscho