Re: [PATCH 22/22] sequencer: refactor write_message()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 9, 2016, 14:40 UTC
Message-ID: <alpine.DEB.2.20.1609091639430.129229@virtualbox>
In-Reply-To: <dbc1b08c-a151-29ab-a5a2-45343ca556d6@gmail.com>

Hi Kuba,

On Fri, 2 Sep 2016, Jakub Narębski wrote:

Show 18 quoted lines

> W dniu 01.09.2016 o 16:20, Johannes Schindelin pisze:
> > On Thu, 1 Sep 2016, Jakub Narębski wrote: 
> >> W dniu 29.08.2016 o 10:06, Johannes Schindelin pisze:
> 
> >>>  	if (commit_lock_file(&msg_file) < 0)
> >>>  		return error(_("Error wrapping up %s."), filename);
> >>
> >> Another "while at it"... though the one that can be safely postponed
> >> (well, the make message easier to understand part, not the quote
> >> filename part):
> >>
> >>   		return error(_("Error wrapping up writing to '%s'."), filename);
> > 
> > As I inherited this message, I'll keep it.
> 
> Well, please then add quotes while at it, at least, for consistency
> 
>   		return error(_("Error wrapping up '%s'."), filename);

I may do that as a final patch, once all the other concerns are addressed. I really do not want to change the error message during the conversion.

Ciao, Dscho