Re: [PATCH 12/22] sequencer: refactor the code to obtain a short commit name

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 29, 2016, 11:04 UTC
Message-ID: <alpine.DEB.2.20.1608291301350.129229@virtualbox>
In-Reply-To: <1472463570.4265.24.camel@kaarsemaker.net>

Hi Dennis,

On Mon, 29 Aug 2016, Dennis Kaarsemaker wrote:

Show 5 quoted lines

> On ma, 2016-08-29 at 10:05 +0200, Johannes Schindelin wrote:
> 
> <snip actual commit>
> 
> I fail to see the point of this patch, would you mind enlightening me?

Two reasons:

1) by refactoring it into a function, the code is more DRY (with all the
advantages that come with it, such as: only a single point to change if
changing the behavior)

2) it is easier to reuse the code in upcoming patches (that would be in
the next patch series)

Will amend the commit message.

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.