Re: [PATCH v3 16/25] sequencer: support amending commits

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 18, 2016, 15:56 UTC
Message-ID: <xmqqlgxlr6q0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1610181352010.197091@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 16 quoted lines

> On Mon, 17 Oct 2016, Junio C Hamano wrote:
>
>> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>> 
>> > This teaches the run_git_commit() function to take an argument that will
>> > allow us to implement "todo" commands that need to amend the commit
>> > messages ("fixup", "squash" and "reword").
>> 
>> Likewise to 15/25, i.e. Good, though the growth by these two steps
>> starts to make me wonder if these three options should be crammed
>> into an unsigned "flags" bitword.
>
> After looking at the diff with the added complications of ORing and ANDing
> the flags, I'd much rather prefer to stay with the three flags being kept
> separately. It's not like we need to save bits, but we need to preserve
> readability as much as possible, I'd wager.

That's OK. I just wanted to make sure pros-and-cons have been already considered.

The primary merit of using flags bitword is not to save bits; it is done to limit the damage to the codebase when we need to add yet another knob, by the way.