Re: [PATCH 16/22] sequencer: prepare for rebase -i's GPG settings
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 31, 2016, 20:12 UTC
- Message-ID
- <xmqqmvjszoia.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <104de15c-77e8-9474-9579-4934ca8a4323@gmail.com>
Jakub Narębski <jnareb@gmail.com> writes:
Show 6 quoted lines
>> + else {
>> + opts->gpg_sign = buf.buf + 2;
>> + strbuf_detach(&buf, NULL);
>
> Wouldn't we leak 2 characters that got skipped? Maybe xstrdup would
> be better (if it is leaked, and not reattached)?An attempt to avoid leaking by calling free(opts->gpg_sign) would make it crash, which would be even worse ;-).