Re: [PATCH v2 24/25] sequencer: quote filenames in error messages
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 6, 2016, 13:41 UTC
- Message-ID
- <alpine.DEB.2.20.1610061541300.35196@virtualbox>
- In-Reply-To
- <xmqq60q26mfw.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Sun, 11 Sep 2016, Junio C Hamano wrote:
Show 16 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> > This makes the code consistent by fixing quite a couple of error messages.
>
> Looks OK. While at it, we may want another one to downcase the
> first word, perhaps?
>
> These may not be messages added by your series and can be left
> outside this series, but I have to point out that
>
> if (commit_lock_file(&msg_file) < 0)
> return error(_("Error wrapping up '%s'."), filename);
>
> results in "error: Error wrapping up", which sounds quite funny.
>
> "failed to finalize" or something would flow a bit better, I'd say.Fair enough. I added a patch to make it so.
Thanks, Dscho