Re: [PATCH v3 12/25] sequencer: remember the onelines when parsing the todo file

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 12, 2016, 11:49 UTC
Message-ID: <alpine.DEB.2.20.1610121347361.3492@virtualbox>
In-Reply-To: <xmqq1szmaemr.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Tue, 11 Oct 2016, Junio C Hamano wrote:

Show 15 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > diff --git a/sequencer.c b/sequencer.c
> > index afc494e..7ba5e07 100644
> > --- a/sequencer.c
> > +++ b/sequencer.c
> > @@ -708,6 +708,8 @@ static int read_and_refresh_cache(struct replay_opts *opts)
> >  struct todo_item {
> >  	enum todo_command command;
> >  	struct commit *commit;
> > +	const char *arg;
> > +	int arg_len;
> >  	size_t offset_in_buf;
> 
> micronit: you can make it to size_t and lose the cast below, no?

No. The primary users of arg_len call a printf() style function with %.*s, expecting an int. So your suggestion would lose one cast, but introduce at least four casts in return.

Ciao, Dscho