Re: [PATCH 01/22] sequencer: use static initializers for replay_opts
- From
Jakub Narębski <jnareb@gmail.com>
- Date
- Aug 29, 2016, 17:41 UTC
- Message-ID
- <8c36fb5f-42a2-e4a7-1b7d-c8e60de593e4@gmail.com>
- In-Reply-To
- <1472462360.4265.21.camel@kaarsemaker.net>
W dniu 29.08.2016 o 11:19, Dennis Kaarsemaker pisze:
Show 7 quoted lines
> On ma, 2016-08-29 at 10:03 +0200, Johannes Schindelin wrote:
>
>> +#define REPLAY_OPTS_INIT { -1, -1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL, NULL, 0, 0, NULL }
>
> This looked off to me, as it replaces memset(..., 0, ...) so is not
> 100% equivalent. But the changed functions both set opts.action and
> call parse_args which sets opts.subcommand.This information would be nice to have in the commit message.
-- Jakub Narębski