Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 6, 2016, 18:41 UTC
Message-ID: <xmqqa8ehl3qv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <5ed8aaea-9fbe-11b0-49b7-1b42567d4918@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

Show 7 quoted lines

> Let me take the opportunity to say
>
>    Thank You Very Much!
>
> for the new implementation of rebase -i. I'm using your branch
> rebase-i-extra, and it is such a pleasure to work with on Windows
> compared to the old fully scripted version.

Thanks for testing.

Having more guinea pigs ^W ^W testers before the series is reviewed here would be a nice boost and would hopefully encourage more reviewers to help the series into a good shape to be upstreamed ;-)

Show 9 quoted lines

> ---- 8< ----
> [PATCH] sequencer: strip CR from the end of exec insns
>
> It is not unheard of that editors on Windows write CRLF even if the file
> originally had only LF. This is particularly awkward for exec lines of a
> rebase -i todo sheet. Take for example the insn "exec echo": The shell
> script parser (either of the sequencer or of the shell that is invoked,
> I do not know) splits at the LF and leaves the CR attached to "echo",
> which leads to the unknown command "echo\r".

Interesting find. So it's not just ltrim is being lenient only to end-user typo, but not doing rtrim can actively hurt ;-)

> Work it around by stripping CR before the command specified with exec is
> passed to the shell.

Makes sense.