Re: [PATCH 10/22] sequencer: avoid completely different messages for different actions
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 9, 2016, 14:23 UTC
- Message-ID
- <alpine.DEB.2.20.1609091613000.129229@virtualbox>
- In-Reply-To
- <198780d4-dbef-c0cc-fb4c-fc8986a33002@gmail.com>
Hi Kuba,
On Fri, 2 Sep 2016, Jakub Narębski wrote:
Show 18 quoted lines
> W dniu 01.09.2016 o 09:52, Johannes Schindelin pisze:
> > On Wed, 31 Aug 2016, Jakub Narębski wrote:
> >> CC-ed to Jiang Xin, L10N coordinator.
> >> W dniu 29.08.2016 o 10:05, Johannes Schindelin pisze:
>
> [...]
> >>> - /* Different translation strings for cherry-pick and revert */
> >>> - if (opts->action == REPLAY_PICK)
> >>> - error(_("Your local changes would be overwritten by cherry-pick."));
> >>> - else
> >>> - error(_("Your local changes would be overwritten by revert."));
> >>> + error(_("Your local changes would be overwritten by %s."),
> >>> + action_name(opts));
> >>
> >> If I understand it correctly, it would make "revert" or "cherry-pick"
> >> untranslated part of error message. You would need to use translation
> >> on the result with "_(action_name(opts))", you would have to mark
> >> todo_command_strings elements for gettext lexicon with N_(...).Okay, that is easy enough.
Ciao, Dscho