Re: [PATCH v4 05/25] sequencer: eventually release memory allocated for the option values
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 20, 2016, 12:16 UTC
- Message-ID
- <alpine.DEB.2.20.1610201415570.3264@virtualbox>
- In-Reply-To
- <xmqq1szdnnvc.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Tue, 18 Oct 2016, Junio C Hamano wrote:
Show 15 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > >> > To remedy that, we now take custody of the option values in question, > >> > requiring those values to be malloc()ed or strdup()ed > >> > >> That is the approach this patch takes, so "eventually release" in > >> the title is no longer accurate, I would think. > > > > To the contrary, we now free() things in remove_state(), so we still > > "eventually release" the memory. > > OK. We call a change to teach remove_state() to free the resource > does more commonly as "plug leaks"; the word "eventually" gave me an > impression that we are emphasizing the fact that we do not free(3) > immediately but lazily do so at the end, hence my response.
I changed the commit subject, hopefully to your liking, Dscho