From: Junio C Hamano Date: Tue, 11 Oct 2016 16:58:01 GMT Subject: Re: [PATCH v3 07/25] sequencer: completely revamp the "todo" script parsing Message-ID: In-Reply-To: Johannes Schindelin writes: > In the end, I decided to actually *not* use strbuf_add_unique_abbrev() > here because it really makes the code very much too ugly after the > introduction of short_commit_name(): It's perfectly fine not to use that function when it does not make sense; we shouldn't use it (or anything for that matter) just for the sake of using it.