Re: Re* [PATCH v3 05/25] sequencer: eventually release memory allocated for the option values
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 13, 2016, 10:51 UTC
- Message-ID
- <alpine.DEB.2.20.1610131251000.197091@virtualbox>
- In-Reply-To
- <xmqqk2dd4efs.fsf_-_@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 12 Oct 2016, Junio C Hamano wrote:
Show 14 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > On Tue, 11 Oct 2016, Junio C Hamano wrote: > > > >> The only reason why the OPT_STRDUP appeared convenient was because > >> options[] element happened to use a field in the structure directly. > >> The patch under discussion does an equivalent of > >> > >> app.x_field = xstrdup_or_null(opt_x); > > > > Oh, that xstrdup_or_null() function slipped by me. My local patches use it > > now. > > It has slipped many people ;-)
Thanks, I feel better now ;-)
Ciao, Dscho