Re: [PATCH v2 25/25] sequencer: remove bogus hint for translators
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 6, 2016, 14:18 UTC
- Message-ID
- <alpine.DEB.2.20.1610061559450.35196@virtualbox>
- In-Reply-To
- <xmqqa8fe6mln.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Sun, 11 Sep 2016, Junio C Hamano wrote:
Show 27 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> > When translating error messages, we need to be careful *not* to translate
> > the todo commands such as "pick", "reword", etc because they are commands,
> > and Git would not understand translated versions of those commands.
> >
> > Therefore, translating the commands in the error messages would simply be
> > misleading.
>
> This comes from b9c993e0 ("i18n: git-revert literal "me" messages",
> 2011-02-22) where it said
>
> Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>
> i18n: git-revert literal "me" messages
>
> Translate messages that use the `me' variable. These are all error
> messages referencing the command name, so the name shouldn't be
> translated.
>
> Reported-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> This looks like a positive attempt to remind translators that their
> translation must flow with these literal command names that will not
> get translated in place, not a bogus hint at all, at least to me.Alright, I misread it to mean: "You need to translate these terms".
I fixed it by skipping this patch, and amending the "revamp the todo parsing" patch: the first %s now actually refers to the much more helpful todo command rather than the overall Git command.
Thanks, Dscho