Re: [PATCH 01/22] sequencer: use static initializers for replay_opts
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 29, 2016, 10:54 UTC
- Message-ID
- <alpine.DEB.2.20.1608291254240.129229@virtualbox>
- In-Reply-To
- <1472462360.4265.21.camel@kaarsemaker.net>
Hi Dennis,
On Mon, 29 Aug 2016, Dennis Kaarsemaker wrote:
Show 7 quoted lines
> On ma, 2016-08-29 at 10:03 +0200, Johannes Schindelin wrote:
>
> > +#define REPLAY_OPTS_INIT { -1, -1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL, NULL, 0, 0, NULL }
>
> This looked off to me, as it replaces memset(..., 0, ...) so is not
> 100% equivalent. But the changed functions both set opts.action and
> call parse_args which sets opts.subcommand.Okay... Do you want me to change anything?
Ciao, Dscho