Re: [PATCH 20/22] sequencer: remember do_recursive_merge()'s return value

From: Jakub Narębski <jnareb@gmail.com>
Date: Aug 29, 2016, 20:32 UTC
Message-ID: <99fd1126-53d1-36e4-facd-7e18ba06e3c0@gmail.com>
In-Reply-To: <1f79d41e3417a0b1f0cffccc40e97f1a2c5ef987.1472457609.git.johannes.schindelin@gmx.de>

W dniu 29.08.2016 o 10:06, Johannes Schindelin pisze:

Show 10 quoted lines

> diff --git a/sequencer.c b/sequencer.c
> index 5ec956f..0614b90 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -623,7 +623,7 @@ static int do_pick_commit(enum todo_command command, struct commit *commit,
>  	const char *base_label, *next_label;
>  	struct commit_message msg = { NULL, NULL, NULL, NULL };
>  	struct strbuf msgbuf = STRBUF_INIT;
> -	int res, unborn = 0, allow;
> +	int res = 0, unborn = 0, allow;

Not that I am against this part of change, making initialization explicit, but why we are initializing automatic variables with 0, which would be the default value anyway? I thought our coding guidelines discourage initializing with 0 or NULL...

Puzzled,

-- 
Jakub Narębski