Re: [PATCH v5 22/27] sequencer: teach write_message() to append an optional LF

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 23, 2016, 09:34 UTC
Message-ID: <alpine.DEB.2.20.1610231129410.3264@virtualbox>
In-Reply-To: <xmqqmvhxbljm.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Fri, 21 Oct 2016, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > This commit prepares for future callers that will have a pointer/length
> > to some text to be written that lacks an LF, yet an LF is desired.
> > Instead of requiring the caller to append an LF to the buffer (and
> > potentially allocate memory to do so), the write_message() function
> > learns to append an LF at the end of the file.
> 
> As no existing callers need this, it probably is better left out and
> added to the series that actually needs the new feature as a
> preparatory step.

Apart from this patch series being semantically the right place ("prepare-sequencer"), there is also the following consideration: The next patch series is already quite long. Taking this current patch series into account, which started out as a 22-patch series and needed to bloat by 25% through four subsequent iterations, it is probably not a wise idea to move this patch to a patch series that already weighs 34 patches.

So I respectfully, and forcefully, disagree, Dscho