Re: [PATCH v3 12/25] sequencer: remember the onelines when parsing the todo file
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 12, 2016, 16:24 UTC
- Message-ID
- <xmqqbmyp5ycw.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.2.20.1610121347361.3492@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
>> > + const char *arg; >> > + int arg_len; >> > size_t offset_in_buf; >> >> micronit: you can make it to size_t and lose the cast below, no? > > No. The primary users of arg_len call a printf() style function with %.*s, > expecting an int. So your suggestion would lose one cast, but introduce at > least four casts in return.
Actually my point was not the number of casts required, but more about using the correct type to store things. Granted, I do not expect each of the lines would ever get too long to exceed "int" (but fit in "size_t") in practice, and from that point of view, one may be able to argue that "int" and "size_t" are both correct types, but that argument applies equally to offset_in_buf, so...