Re: [PATCH v2 20/25] sequencer: left-trim lines read from the script

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 6, 2016, 13:08 UTC
Message-ID: <alpine.DEB.2.20.1610061459390.35196@virtualbox>
In-Reply-To: <xmqqr38p3z1i.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 12 Sep 2016, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> I do not offhand see why we want to be lenient here,
> >> especially only to the left.
> >
> > Postel's Law.
> 
> How would that compare/relate to yagni, though?

I did need it, though. Blame it on being overworked or simply tired: I ended up inserting a spurious space before a "fixup" command. This command was handled as intended by the scripted rebase -i, and with the patch in question the rebase--helper agreed, too.

Note: we have no problem to the right because we do handle variable-length
whitespace between command and SHA-1, and we do not care one iota about
the exact form of the oneline (hence right-stripping is not necessary).

Ciao, Dscho