Re: [PATCH v4 20/25] sequencer: refactor write_message()

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 21, 2016, 15:40 UTC
Message-ID: <xmqqr379d82b.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1610211343310.3264@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 13 quoted lines

>> Ah, make that four steps.  The final one is:
>> 
>>     - add append_eol parameter that nobody uses at this step in the
>>       series.
>>
>> This is a new feature to the helper.  While it is OK to have it as a
>> preparatory step in this series, it is easier to understand if it
>> kept as a separate step.  It is even more preferrable if it is made
>> as a preparatory step in a series that adds a caller that passes
>> true to append_eol to this helper...
>
> Done,
> Dscho

Hmm, what has been done exactly? I still see append_eol in v5 where nobody uses it yet. Confused...

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.