From: Johannes Schindelin Date: Mon, 29 Aug 2016 11:04:10 GMT Subject: Re: [PATCH 12/22] sequencer: refactor the code to obtain a short commit name Message-ID: In-Reply-To: <1472463570.4265.24.camel@kaarsemaker.net> Hi Dennis, On Mon, 29 Aug 2016, Dennis Kaarsemaker wrote: > On ma, 2016-08-29 at 10:05 +0200, Johannes Schindelin wrote: > > > > I fail to see the point of this patch, would you mind enlightening me? Two reasons: 1) by refactoring it into a function, the code is more DRY (with all the advantages that come with it, such as: only a single point to change if changing the behavior) 2) it is easier to reuse the code in upcoming patches (that would be in the next patch series) Will amend the commit message. Ciao, Dscho