Re: [PATCH v3 2/8] cmake: generate the shell/perl/python scripts and templates, translations
- From
Sibi Siddharthan <sibisiddharthan.github@gmail.com>
- Date
- Jun 8, 2020, 20:07 UTC
- Message-ID
- <CAKiG+9VcAx2xRFzrqQpXFc+sVuRZ2ydoVYTpCtWpi9z2Oa0fCw@mail.gmail.com>
- In-Reply-To
- <CAKiG+9Ue1fqrzqHduZY4Pnsh4q+Thqq618JymkonmVhGewmM1g@mail.gmail.com>
Hi Junio,
I have done the suggested changes namely: 1) Format code inside check_c_source_compiles/runs 2) Moved the changelog of the patch series from the commit messages to the cover letter 3) parse for SCRIPT_LIB 4) glob templates and po files 5) add logic as to where the template file should be built.
Any other changes I should do before I a new version of the patch series?
Thank You, Sibi Siddharthan