Re: [PATCH v3 8/8] ci: modification of main.yml to use cmake for vs-build job
- From
Đoàn Trần Công Danh <congdanhqx@gmail.com>
- Date
- May 30, 2020, 14:14 UTC
- Message-ID
- <20200530141448.GD2151@danh.dev>
- In-Reply-To
- <bb329d16ce0999e198addf83d56f75762c830e1f.1590759624.git.gitgitgadget@gmail.com>
On 2020-05-29 13:40:24+0000, Sibi Siddharthan via GitGitGadget <gitgitgadget@gmail.com> wrote:
> To check for ICONV_OMITS_BOM libiconv.dll needs to be in the working > directory of script or path. So we copy the dlls before we configure.
If ICONV_OMITS_BOM is such a troublemaker for CMake, I'm fine with not supporting it at all.
It seems like noone except me have interest in ICONV_OMITS_BOM.
Show 7 quoted lines
> @@ -302,4 +308,4 @@ jobs: > steps: > - uses: actions/checkout@v1 > - run: ci/install-dependencies.sh > - - run: ci/test-documentation.sh > + - run: ci/test-documentation.sh > \ No newline at end of file
Please fix your editor ;)
-- Danh