Re: [PATCH v2 09/11] cmake: relocated script file contrib/buildsystems
On Wed, May 13, 2020 at 2:40 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
>
> "Sibi Siddharthan via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
> >
> > The CMake script has been relocated to contrib/buildsystems.
> > The changes made to the script involves pointing to correct location
> > of the source files.
>
> This does match what the list agreed to do. Why isn't this done as
> part of [01/11]? If there is no technical reason not to, I'd
> strongly prefer to see it done from the very beginning. The same
> comment applies to the next step.
Show 8 quoted lines
>
> Thanks.
>
> > Signed-off-by: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
> > ---
> > .../buildsystems/CMakeLists.txt | 76 +++++++++++--------
> > 1 file changed, 45 insertions(+), 31 deletions(-)
> > rename CMakeLists.txt => contrib/buildsystems/CMakeLists.txt (92%)
Sibi Siddharthan <sibisiddharthan.github@gmail.com>