Re: [PATCH v4 6/8] cmake: support for building git on windows with mingw

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 19, 2020, 17:29 UTC
Message-ID: <xmqqbllfhslz.fsf@gitster.c.googlers.com>
In-Reply-To: <CAKiG+9VCcH+CGc8=e22Xjc7z=-HL3vbDTDq9a4zZ9ONdmgTpvw@mail.gmail.com>

Sibi Siddharthan <sibisiddharthan.github@gmail.com> writes:

Show 10 quoted lines

>> Let's not worry about cross-platform and instead stick to Windows
>> and nothing else for now to expedite the process.  As long as it is
>> advertised as such, nobody would complain that it does not work on
>> Linux or macOS.
>>
>
> Okay.
>
> Just for your information.
> This is the exact diff that needs to be added to address the issue.

I do not care how small the diff is. This won't be the last such case that needs a workaround, and I do not want to see us die from thousands of little cuts.

If anything, a diff that removes things that are needed only because we try to work on non-Windows systems would be more interesting to see. If it removes a single ifdef(), that would be worth applying.

Thanks.