Re: [PATCH v2 09/11] cmake: relocated script file contrib/buildsystems

From: Junio C Hamano <gitster@pobox.com>
Date: May 12, 2020, 21:09 UTC
Message-ID: <xmqqftc4c123.fsf@gitster.c.googlers.com>
In-Reply-To: <9c674372fb58aa42e339c0a96c432283c4b0a894.1589302255.git.gitgitgadget@gmail.com>

"Sibi Siddharthan via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines

> From: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
>
> The CMake script has been relocated to contrib/buildsystems.
> The changes made to the script involves pointing to correct location
> of the source files.

This does match what the list agreed to do. Why isn't this done as part of [01/11]? If there is no technical reason not to, I'd strongly prefer to see it done from the very beginning. The same comment applies to the next step.

Thanks.

Show 5 quoted lines

> Signed-off-by: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
> ---
>  .../buildsystems/CMakeLists.txt               | 76 +++++++++++--------
>  1 file changed, 45 insertions(+), 31 deletions(-)
>  rename CMakeLists.txt => contrib/buildsystems/CMakeLists.txt (92%)