Re: [PATCH v2 11/11] ci: modification of main.yml to use cmake for vs-build job

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 25, 2020, 21:40 UTC
Message-ID: <nycvar.QRO.7.76.6.2005252338090.56@tvgsbejvaqbjf.bet>
In-Reply-To: <CAKiG+9UXa_1tfJ49gXGQCKTK5hqmVSAV2SqEc4iZCT54i18h6Q@mail.gmail.com>

Hi Sibi,

On Tue, 26 May 2020, Sibi Siddharthan wrote:

> The difference in build between Linux platforms and Windows would be
> 8-15 lines of code atmost . I see no point in the extra Linux stuff to
> be a burden for the reviewers.

I agree that this does not constitute a big burden.

Linux support in the CMake system _might_ come in real handy in certain circumstances. For example, if I understand correctly cppcheck uses the CMake configuration to figure out which source files to analyze, and with which #define's.

So there might be some previously-underappreciated benefit to having a CMake configuration that works on Linux, even if it is not the recommended way to build Git on Linux.

Thank you for your incredible work on the CMake front, Dscho