Re: [PATCH 1/8] Introduce CMake support for configuring Git on Linux
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Apr 25, 2020, 17:07 UTC
- Message-ID
- <20200425170740.GA6421@camp.crustytoothpaste.net>
- In-Reply-To
- <70ab1f03dd5413256166bf9db47be47b746ea6b1.1587700897.git.gitgitgadget@gmail.com>
On 2020-04-24 at 04:01:30, Sibi Siddharthan via GitGitGadget wrote:
Show 11 quoted lines
> diff --git a/CMakeLists.txt b/CMakeLists.txt > new file mode 100644 > index 00000000000..73703bd321f > --- /dev/null > +++ b/CMakeLists.txt > @@ -0,0 +1,528 @@ > +# > +# Copyright (c) 2020 Sibi Siddharthan > +# > + > +cmake_minimum_required(VERSION 3.14)
I don't plan a full review of this series, but I wanted to point out that this version is newer than what's in Debian 10, so this isn't practically buildable on many systems.
If we wanted to add CMake support, even just for Linux and Windows, I'd want to see it functional on the latest versions of the major distros, at the very least. Ideally it would function using the system packages on all security-supported versions of the major distros, since our Makefile does right now.
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204