Re: [PATCH 0/8] CMake build system for git
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 6, 2020, 21:27 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2005062326350.56@tvgsbejvaqbjf.bet>
- In-Reply-To
- <CAKiG+9WzQdFa1qM4dKUu8O7k+Q8JGsDMGQg-2GRJr=AJye6wJg@mail.gmail.com>
Hi Sibi,
On Tue, 5 May 2020, Sibi Siddharthan wrote:
Show 22 quoted lines
> Hi there, > > I have made the following changes as suggested: > 1) The CMake script works from contrib/cmake now. > 2) The CMake script parses the Makefile for > SCRIPT_SH > SCRIPT_PERL > TEST_BUILTINS_OBJS > LIB_OBJS > BUILTIN_OBJS > XDIFF_OBJS > VCSSVN_OBJS > 3) Philip suggested to change the error message if sh/bash was not > found on windows. > 4) CMake now tests for ICONV_OMITS_BOM, NO_ST_BLOCKS_IN_STRUCT_STAT. > > Regarding the commits, since 1,2,4 are additions to the script, is it > acceptable for those changes to be staged in the next commits? > Regarding the workflow file(main.yml), I modified the vs-build and > test steps, should I drop the commit or should I keep the changes(a > modification is further needed if CMake is going to be used for > vs-build)
Yes, I think it will be crucial to use CMake for vs-build, to keep the CMake support functional.
Ciao, Dscho