Re: [PATCH v2 02/11] cmake: generate the shell/perl/python scripts and templates, translations
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 12, 2020, 21:19 UTC
- Message-ID
- <xmqq7dxgc0mc.fsf@gitster.c.googlers.com>
- In-Reply-To
- <ca242cf5bda74aafca6c169ad53ce33a62761027.1589302254.git.gitgitgadget@gmail.com>
"Sibi Siddharthan via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 7 quoted lines
> From: Sibi Siddharthan <sibisiddharthan.github@gmail.com> > > This patch implements the placeholder substitution to generate, say, > `git-request-pull` from `git-request-pull.sh`. > > The shell/perl/python scripts and template are generated using CMake > (very similar to what sed does).
We do not say "This patch does X" or "I do Y in this patch". perhaps.
Implement the placeholder substitution to generate scripted Porcelain commands, e.g. git-request-pull out of git-request-pull.sh
Generate scripts and templates using CMake, instead of using sed like the build procedure in the Makefile does.