Re: [PATCH 0/8] CMake build system for git

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 24, 2020, 21:43 UTC
Message-ID: <xmqq8sikblv2.fsf@gitster.c.googlers.com>
In-Reply-To: <CAKiG+9V_nZUXf2a689vZ54rG+xTCFMGcJe_7Av-khaxxuijERg@mail.gmail.com>

Sibi Siddharthan <sibisiddharthan.github@gmail.com> writes:

Show 6 quoted lines

> The goal would be to maintain a CMake build for Git keeping it in sync
> with the Makefile.
> The Makefile is not going to be replaced at all. The CMake script for
> now only supports Linux and Windows.
> It does not support BSD, Solaris and others, whereas the Makefile does
> support them.

So you are doing (1). I already said that I feel that engineering burden to divert resources for CMake support would be unacceptably high.

Whenever any of our developers need to add source files, Makefile configuration knobs that people can add to config.mak, etc., you are forcing them to figure out where in the CMakefile to add them or devise ways to allow builders who do not use config.mak (because they use CMake) to do similar tweaks.

Any patch that is acceptable to the current project would become unacceptable because they lack updates to CMake part, but I suspect we do not have enough people who are so much devoted to give a good review if updates to CMake part are added. And it is unclear why it would be beneficial to slow our existing developers down by forcing them to become familiar with CMake.

So..., I am not just "still not convinced", but I am even more convinced that we do not want this series, after thinking about it longer.

Thanks.