Re: [PATCH 0/8] CMake build system for git

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 1, 2020, 19:32 UTC
Message-ID: <nycvar.QRO.7.76.6.2005012130010.18039@tvgsbejvaqbjf.bet>
In-Reply-To: <CAKiG+9U2Eg5yvT4XjgpMUXu4OV-8JF9Hp_ou_P6twxfqJ1tEYA@mail.gmail.com>

Hi Sibi,

[please avoid top-posting on this list, but do reply inline instead, that is much preferred.]

On Wed, 29 Apr 2020, Sibi Siddharthan wrote:

> Adding the CMake script to contrib/buildsystem is a good option.

I'd actually prefer it to live in a different subdirectory: what is in contrib/buildsystem/ uses the technique of running `make` in a dry-run mode, parsing the output, and then generating project files. But that is not what CMakeLists.txt is about.

How about contrib/cmake/?

> Is there any changes (apart from the CMakeLists.txt critique and) that
> I have to do on my part?

No, I think that's it!

Thanks, Dscho

Show 39 quoted lines

>
> Thank You,
> Sibi Siddharthan
>
> On Wed, Apr 29, 2020 at 2:37 AM Jeff King <peff@peff.net> wrote:
> >
> > On Tue, Apr 28, 2020 at 08:52:37PM +0700, Danh Doan wrote:
> >
> > > On 2020-04-27 16:12:28-0400, Jeff King <peff@peff.net> wrote:
> > > > On Mon, Apr 27, 2020 at 04:08:52PM -0400, Jeff King wrote:
> > > >
> > > > > Skimming the patches, I do wish I didn't see so much repetition with the
> > > > > existing Makefile. I know that some of the logic will just have to be
> > > > > ported manually, but surely we could be pulling things like the list of
> > > > > libgit_SOURCES from the Makefile as the single source of truth?
> > > >
> > > > Thinking I surely couldn't be the only one to think of this, I dug
> > > > further into some of the sub-threads. And indeed, it seems like you are
> > > > on the same page here.
> > > >
> > > > IMHO it is worth making the cmake file depend as much as possible on
> > > > what's in the Makefile.
> > >
> > > Please correct me if I were wrong (I recall this from my memory
> > > without checking anything).
> > >
> > > The worst thing about CMake is we can't override (Make's) variable
> > > in Makefile generated by CMake.
> >
> > I really don't know enough about cmake to say one way or the other. I
> > can well believe there are parts of the Makefile that will need to be
> > manually translated, and that it may not ever hit full parity.
> >
> > But as long as it just a tool for people using Visual Studio, and if
> > they are happier being able to use that tool, even with a few
> > deficiencies, then it may still be worth doing.
> >
> > -Peff
>