Re: [PATCH v2 06/11] cmake: support for building git on windows with mingw

From: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
Date: May 14, 2020, 18:27 UTC
Message-ID: <CAKiG+9Uozz0q_Jk2dPhrh7nKCoObeJWZ-zyX5cr0Zc4Q_0YVsA@mail.gmail.com>
In-Reply-To: <20200514152559.GA1939@danh.dev>

On Thu, May 14, 2020 at 8:56 PM Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:

Show 37 quoted lines

>
> Hi Sibi,
>
> On 2020-05-12 16:50:49+0000, Sibi Siddharthan via GitGitGadget <gitgitgadget@gmail.com> wrote:
> > From: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
> > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > index 47d3f3c2866..9625e41886f 100644
> > --- a/CMakeLists.txt
> > +++ b/CMakeLists.txt
> > @@ -13,9 +13,12 @@ project(git
> >       VERSION ${git_version}
> >       LANGUAGES C)
> >
> > +
>
> This newline maybe left from debugging. (and other new newline below).
>
> > +#Platform Specific
> > +if(${CMAKE_SYSTEM_NAME} STREQUAL "Windows")
>
> Please drop ${} around CMAKE_SYSTEM_NAME, here (and other if)
> Or user may accidental messed up.
> ------------8<----------------
> $ cat CMakeLists.txt
> project(test)
> message("This is ${CMAKE_SYSTEM_NAME}")
> if (${CMAKE_SYSTEM_NAME} STREQUAL "Windows")
>         message("Yes, STREQUAL Windows")
> endif()
> $ cmake . -DLinux=Windows
> This is Linux
> Yes, STREQUAL Windows
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /tmp
> ---------------->8--------------
>

Thanks for pointing it out, will fix it ASAP.

Thank You, Sibi Siddharthan

>
> --
> Danh