Re: [PATCH v2 11/11] ci: modification of main.yml to use cmake for vs-build job
- From
Sibi Siddharthan <sibisiddharthan.github@gmail.com>
- Date
- May 25, 2020, 19:16 UTC
- Message-ID
- <CAKiG+9Uz4YG=Hq9PRN8EhFF_agXNUPRnYjetY=ZNVRE6_VDAew@mail.gmail.com>
- In-Reply-To
- <CAKiG+9VXk1vdMM1amQK6pnHcn9H_93-3fkqgK4nwKf=GtrDGyg@mail.gmail.com>
Hi Junio,
I have finished the changes you have asked for. 1) Relocating the CMake script to contrib/buildsystems from patch 01/xx. 2) Parse the Makefile for sources from patch 01/xx. 3) Reworded the commit messages you pointed out. 4) Rebased the ST_BLOCKS_IN_STRUCT_STAT and ICONV_OMITS_BOM to patch 01/xx to make the review process easier.
No new features will be introduced in the script, to make the review process easier.
I have looked at the GIT-VERSION-GEN script and the logic it uses to determine the version of git. The logic is a bit complicated to be implemented in a CMake script, so I am skipping it for now.
Any other changes I should make before I submit PATCH v3?
Thank You, Sibi Siddharthan