Re: [PATCH v4 6/8] cmake: support for building git on windows with mingw

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 18, 2020, 04:43 UTC
Message-ID: <xmqq8sglq8zn.fsf@gitster.c.googlers.com>
In-Reply-To: <CAKiG+9X66yf_F8F3XuYFdFyBWiFRZ_rf0Y1mE5LVCjsi-AzKbg@mail.gmail.com>

Sibi Siddharthan <sibisiddharthan.github@gmail.com> writes:

Show 14 quoted lines

> On Mon, Jun 15, 2020 at 7:33 PM Øystein Walle <oystwa@gmail.com> wrote:
>>
>> > +if(WIN32)
>> > +     set(EXE_EXTENSION .exe)
>> > +else()
>> > +     set(EXE_EXTENSION)
>> > +endif()
>>
>> You can probably use CMAKE_EXECUTABLE_SUFFIX here. See:
>> https://cmake.org/cmake/help/latest/variable/CMAKE_EXECUTABLE_SUFFIX.html
>>
>
> Could have done it that way, will try to change it once the patch
> series gets merged with next or master.

If it is something that makes the result even simpler than the above quoted 5 lines, I do not see a reason to postpone it and use that simpler way from the beginning.

Thanks.