Re: [PATCH 0/8] CMake build system for git
- From
Đoàn Trần Công Danh <congdanhqx@gmail.com>
- Date
- May 7, 2020, 11:48 UTC
- Message-ID
- <20200507114848.GA32465@danh.dev>
- In-Reply-To
- <CAKiG+9WE08ikv9uzDg30w2w=+chRQs9te8hKbVg2WG0p964RZw@mail.gmail.com>
On 2020-05-07 00:13:25+0530, Sibi Siddharthan <sibisiddharthan.github@gmail.com> wrote:
Show 9 quoted lines
> On Tue, May 5, 2020 at 11:47 PM Junio C Hamano <gitster@pobox.com> wrote: > > > > Sibi Siddharthan <sibisiddharthan.github@gmail.com> writes: > > > > > I have made the following changes as suggested: > > > 1) The CMake script works from contrib/cmake now. > I am confused for 1 though. > I think it would be better to add it as a new commit (between 7/8 and 8/8). > Is this acceptable?
Please make CMake works from contrib/cmake from the first patch in the series.
-- Danh