From: Sibi Siddharthan Date: Mon, 08 Jun 2020 20:07:56 GMT Subject: Re: [PATCH v3 2/8] cmake: generate the shell/perl/python scripts and templates, translations Message-ID: In-Reply-To: Hi Junio, I have done the suggested changes namely: 1) Format code inside check_c_source_compiles/runs 2) Moved the changelog of the patch series from the commit messages to the cover letter 3) parse for SCRIPT_LIB 4) glob templates and po files 5) add logic as to where the template file should be built. Any other changes I should do before I a new version of the patch series? Thank You, Sibi Siddharthan