From: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
Date: Wed, 13 May 2020 20:08:15 GMT
Subject: Re: [PATCH v2 09/11] cmake: relocated script file contrib/buildsystems
Message-ID: <CAKiG+9U04p9KbjrAc-g=yS-O_h8Jd8zvPoUjKG1L=-OybSUgrQ@mail.gmail.com>
In-Reply-To: <xmqqftc4c123.fsf@gitster.c.googlers.com>

On Wed, May 13, 2020 at 2:40 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Sibi Siddharthan via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
> >
> > The CMake script has been relocated to contrib/buildsystems.
> > The changes made to the script involves pointing to correct location
> > of the source files.
>
> This does match what the list agreed to do.  Why isn't this done as
> part of [01/11]?  If there is no technical reason not to, I'd
> strongly prefer to see it done from the very beginning.  The same
> comment applies to the next step.

Okay

>
> Thanks.
>
> > Signed-off-by: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
> > ---
> >  .../buildsystems/CMakeLists.txt               | 76 +++++++++++--------
> >  1 file changed, 45 insertions(+), 31 deletions(-)
> >  rename CMakeLists.txt => contrib/buildsystems/CMakeLists.txt (92%)