Re: [PATCH v4 04/35] upload-pack: convert to a builtin

From: Brandon Williams <bmwill@google.com>
Date: Mar 13, 2018, 19:50 UTC
Message-ID: <20180313195044.GA7638@google.com>
In-Reply-To: <20180313094022.6cbe51d765e2eec61e0cd04c@google.com>

On 03/13, Jonathan Tan wrote:

Show 13 quoted lines

> On Wed, 28 Feb 2018 15:22:21 -0800
> Brandon Williams <bmwill@google.com> wrote:
> 
> > In order to allow for code sharing with the server-side of fetch in
> > protocol-v2 convert upload-pack to be a builtin.
> > 
> > Signed-off-by: Brandon Williams <bmwill@google.com>
> 
> I suggested updating the commit message in my previous review [1], but I
> understand that my comment might have been lost in the ensuing long
> discussion.
> 
> [1] https://public-inbox.org/git/20180221134422.2386e1aca39fe673235590e7@google.com/

Your suggested change to the commit msg isn't quite accurate as you can already run "git-upload-pack --help" today.

-- 
Brandon Williams

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.