Re: [PATCH v3 08/35] connect: discover protocol version outside of get_remote_heads
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Feb 22, 2018, 19:22 UTC
- Message-ID
- <20180222112258.7a71601780be9e42f54c5f61@google.com>
- In-Reply-To
- <20180222181739.GC185096@google.com>
On Thu, 22 Feb 2018 10:17:39 -0800 Brandon Williams <bmwill@google.com> wrote:
Show 22 quoted lines
> > > diff --git a/remote.h b/remote.h > > > index 1f6611be2..2016461df 100644 > > > --- a/remote.h > > > +++ b/remote.h > > > @@ -150,10 +150,11 @@ int check_ref_type(const struct ref *ref, int flags); > > > void free_refs(struct ref *ref); > > > > > > struct oid_array; > > > -extern struct ref **get_remote_heads(int in, char *src_buf, size_t src_len, > > > +struct packet_reader; > > > +extern struct ref **get_remote_heads(struct packet_reader *reader, > > > struct ref **list, unsigned int flags, > > > struct oid_array *extra_have, > > > - struct oid_array *shallow); > > > + struct oid_array *shallow_points); > > > > This change probably does not belong in this patch, especially since > > remote.c is unchanged. > > Yes this hunk is needed, the signature of get_remote_heads changes. It > may be difficult to see that due to the fact that we don't really have a > clear story on how header files are divided up within the project.
Thanks - I indeed didn't notice that the implementation of get_remote_heads() is modified too in this patch.
My initial comment was about just the renaming of "shallow" to "shallow_points", but yes, you're right - I see in the implementation that it is indeed named "shallow_points" there, so this change is justified, especially since you're already changing the signature of this function.