Re: [PATCH v3 07/35] connect: convert get_remote_heads to use struct packet_reader
- From
- Brandon Williams <bmwill@google.com>
- Date
- Feb 23, 2018, 21:30 UTC
- Message-ID
- <20180223213000.GD234838@google.com>
- In-Reply-To
- <CAGZ79kbnioP+12xa2qfaYLyzdeCH8hh2Ri0xHD7rNciJiTYxmg@mail.gmail.com>
On 02/22, Stefan Beller wrote:
Show 23 quoted lines
> > +static enum protocol_version discover_version(struct packet_reader *reader)
> > +{
> ...
> > +
> > + /* Maybe process capabilities here, at least for v2 */
> > + switch (version) {
> > + case protocol_v1:
> > + /* Read the peeked version line */
> > + packet_reader_read(reader);
> > + break;
> > + case protocol_v0:
> > + break;
> > + case protocol_unknown_version:
> > + die("unknown protocol version: '%s'\n", reader->line);
>
> The following patches introduce more of the switch(version) cases.
> And there it actually is a
> BUG("protocol version unknown? should have been set in discover_version")
> but here it is a mere
> die (_("The server uses a different protocol version than we can
> speak: %s\n"),
> reader->line);
> so I would think here it is reasonable to add _(translation).This should be a BUG as it shouldn't ever be unknown at this point. And I'll also drop that comment.
-- Brandon Williams