Re: [PATCH v3 26/35] transport-helper: remove name parameter

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 27, 2018, 23:03 UTC
Message-ID: <20180227230316.GE174036@aiede.svl.corp.google.com>
In-Reply-To: <20180207011312.189834-27-bmwill@google.com>

Brandon Williams wrote:

Show 11 quoted lines

> Commit 266f1fdfa (transport-helper: be quiet on read errors from
> helpers, 2013-06-21) removed a call to 'die()' which printed the name of
> the remote helper passed in to the 'recvline_fh()' function using the
> 'name' parameter.  Once the call to 'die()' was removed the parameter
> was no longer necessary but wasn't removed.  Clean up 'recvline_fh()'
> parameter list by removing the 'name' parameter.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  transport-helper.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Nice.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.