From: Brandon Williams Date: Tue, 13 Mar 2018 19:50:44 GMT Subject: Re: [PATCH v4 04/35] upload-pack: convert to a builtin Message-ID: <20180313195044.GA7638@google.com> In-Reply-To: <20180313094022.6cbe51d765e2eec61e0cd04c@google.com> On 03/13, Jonathan Tan wrote: > On Wed, 28 Feb 2018 15:22:21 -0800 > Brandon Williams wrote: > > > In order to allow for code sharing with the server-side of fetch in > > protocol-v2 convert upload-pack to be a builtin. > > > > Signed-off-by: Brandon Williams > > I suggested updating the commit message in my previous review [1], but I > understand that my comment might have been lost in the ensuing long > discussion. > > [1] https://public-inbox.org/git/20180221134422.2386e1aca39fe673235590e7@google.com/ Your suggested change to the commit msg isn't quite accurate as you can already run "git-upload-pack --help" today. -- Brandon Williams