Re: [PATCH v3 23/35] fetch-pack: support shallow requests

From: Jonathan Tan <jonathantanmy@google.com>
Date: Feb 23, 2018, 19:37 UTC
Message-ID: <20180223113722.ac4a8d3ef18bec31f20e79f7@google.com>
In-Reply-To: <20180207011312.189834-24-bmwill@google.com>

On Tue, 6 Feb 2018 17:13:00 -0800 Brandon Williams <bmwill@google.com> wrote:

Show 7 quoted lines

> @@ -1090,6 +1110,10 @@ static int send_fetch_request(int fd_out, const struct fetch_pack_args *args,
>  	if (prefer_ofs_delta)
>  		packet_buf_write(&req_buf, "ofs-delta");
>  
> +	/* Add shallow-info and deepen request */
> +	if (server_supports_feature("fetch", "shallow", 1))
> +		add_shallow_requests(&req_buf, args);

One more thing I observed when trying to implement the server side in JGit - the last argument should be 0, not 1, right? I don't think that "shallow" should be required on the server unless we really need it.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.