Re: [PATCH v3 14/35] connect: request remote refs using v2

From: Jonathan Tan <jonathantanmy@google.com>
Date: Feb 21, 2018, 22:54 UTC
Message-ID: <20180221145411.35b2ea84747518a499276bdd@google.com>
In-Reply-To: <20180207011312.189834-15-bmwill@google.com>

On Tue, 6 Feb 2018 17:12:51 -0800 Brandon Williams <bmwill@google.com> wrote:

> +extern struct ref **get_remote_refs(int fd_out, struct packet_reader *reader,
> +				    struct ref **list, int for_push,
> +				    const struct argv_array *ref_patterns);

I haven't looked at the rest of this patch in detail, but the type of ref_patterns is probably better as struct string_list, since this is not a true argument array (e.g. with flags starting with --). Same comment for the next few patches that deal with ref patterns.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.