Re: [PATCH v3 32/35] http: allow providing extra headers for http requests

From: Brandon Williams <bmwill@google.com>
Date: Feb 22, 2018, 18:58 UTC
Message-ID: <20180222185853.GJ185096@google.com>
In-Reply-To: <20180221160905.5772106219ded5f16919de46@google.com>

On 02/21, Jonathan Tan wrote:

Show 14 quoted lines

> On Tue,  6 Feb 2018 17:13:09 -0800
> Brandon Williams <bmwill@google.com> wrote:
> 
> > @@ -172,6 +172,8 @@ struct http_get_options {
> >  	 * for details.
> >  	 */
> >  	struct strbuf *base_url;
> > +
> > +	struct string_list *extra_headers;
> 
> Document this? For example:
> 
>   If not NULL, additional HTTP headers to be sent with the request. The
>   strings in the list must not be freed until after the request.

I'll add that.

-- 
Brandon Williams

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.