Re: [PATCH 09/26] transport: store protocol version
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Jan 9, 2018, 18:41 UTC
- Message-ID
- <20180109104125.4cb1a3e545cfe354862e4b8e@google.com>
- In-Reply-To
- <20180103001828.205012-10-bmwill@google.com>
On Tue, 2 Jan 2018 16:18:11 -0800 Brandon Williams <bmwill@google.com> wrote:
Show 9 quoted lines
> diff --git a/transport.c b/transport.c
> index 63c3dbab9..2378dcb38 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -118,6 +118,7 @@ struct git_transport_data {
> struct child_process *conn;
> int fd[2];
> unsigned got_remote_heads : 1;
> + enum protocol_version version;Should this be initialized to protocol_unknown_version? Right now, as far as I can tell, it is zero-initialized, which means protocol_v0.