Re: [PATCH v3 16/35] transport: convert transport_get_remote_refs to take a list of ref patterns

From: Brandon Williams <bmwill@google.com>
Date: Feb 22, 2018, 18:26 UTC
Message-ID: <20180222182647.GF185096@google.com>
In-Reply-To: <20180221145804.f483fb21559f71618812404d@google.com>

On 02/21, Jonathan Tan wrote:

Show 18 quoted lines

> On Tue,  6 Feb 2018 17:12:53 -0800
> Brandon Williams <bmwill@google.com> wrote:
> 
> > -const struct ref *transport_get_remote_refs(struct transport *transport)
> > +const struct ref *transport_get_remote_refs(struct transport *transport,
> > +					    const struct argv_array *ref_patterns)
> >  {
> >  	if (!transport->got_remote_refs) {
> > -		transport->remote_refs = transport->vtable->get_refs_list(transport, 0, NULL);
> > +		transport->remote_refs =
> > +			transport->vtable->get_refs_list(transport, 0,
> > +							 ref_patterns);
> >  		transport->got_remote_refs = 1;
> >  	}
> 
> Should we do our own client-side filtering if the server side cannot do
> it for us (because it doesn't support protocol v2)? Either way, this
> decision should be mentioned in the commit message.

If someone wants to add this in the future they can, but that is outside the scope of this series.

-- 
Brandon Williams