Re: [PATCH v3 14/35] connect: request remote refs using v2

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2018, 21:58 UTC
Message-ID: <xmqq8tbep02f.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180227062128.GG65699@aiede.svl.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 16 quoted lines

> Jonathan Tan wrote:
>> On Thu, 22 Feb 2018 13:26:58 -0500
>> Jeff King <peff@peff.net> wrote:
>
>>> I agree that it shouldn't matter much here. But if the name argv_array
>>> is standing in the way of using it, I think we should consider giving it
>>> a more general name. I picked that not to evoke "this must be arguments"
>>> but "this is terminated by a single NULL".
> [...]
>> This sounds reasonable - I withdraw my comment about using struct
>> string_list.
>
> Marking with #leftoverbits as a reminder to think about what such a
> more general name would be (or what kind of docs to put in
> argv-array.h) and make it so the next time I do a search for that
> keyword.

So are we looking for a natural name to call an array of trings? I personally do not mind argv_array too much, but perhaps we can call it a string_array and then everybody will be happy?